Merged
Conversation
If the popup closes before waitForPopupClose is called,
waitForEvent('close') hangs forever because the event already fired.
Add isClosed() guard to handle this case — matches the pattern
already used in approveSDKPopup.
Fixes flaky beforeAll timeout in sdk-e2e google tests.
bobo-k2
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitForPopupClosewithpopup.isClosed()before callingwaitForEvent('close')waitForEventhangs forever since the event already firedapproveSDKPopupContext
Flaky
sdk-e2e / googleCI failures in superapp: on retry #1,beforeAllcallswaitForPopupClose(sdkPopup)after Google OAuth, but the popup has already closed → 60s timeout →personal_signtest marked failed (0ms, body never ran).Example: https://github.com/StartaleGroup/superapp/actions/runs/23883580601/job/69641946564?pr=1273